Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tasks getting run twice #94539

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Fix tasks getting run twice #94539

merged 1 commit into from
Apr 6, 2020

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Apr 6, 2020 •
edited

This PR fixes #94537

@alexr00
Copy link
Member Author

alexr00 commented Apr 6, 2020

I made a bad refactor that can result in a promise getting resolved twice which in turn causes tasks to get run twice and behave unpredictably.

@alexr00 alexr00 self-assigned this Apr 6, 2020
@alexr00 alexr00 requested a review from dbaeumer April 6, 2020 13:24
@alexr00 alexr00 added this to the March 2020 milestone Apr 6, 2020
@alexr00
Copy link
Member Author

alexr00 commented Apr 6, 2020

Thank you!

@alexr00 alexr00 merged commit ad691b2 into release/1.44 Apr 6, 2020
@alexr00 alexr00 deleted the alexr00/issue94537 branch April 6, 2020 14:59
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbaeumer dbaeumer dbaeumer approved these changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
March 2020
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexr00 @dbaeumer